Update MutinyGenerator#generate signature #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We `Uni<?>` we can avoid an additional redundant conversion
before returning the value in some situations.
For example, if the return value is the result of a native
query:
```
return session.createNativeQuery("...", Long.class).getSingleResult();
```
This is useful because with native queries we don't always know in advance
what value will be returned. And using Object.class might cause
ClassCastExceptions along the way.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| throw new UnsupportedOperationException( "Use generate(Mutiny.Session, Object, Object, EventType) instead" ); | ||
| } | ||
|
|
||
| public abstract Uni<Object> generate(Mutiny.Session session, Object owner, Object currentValue, | ||
| EventType eventType); | ||
| public abstract Uni<?> generate(Mutiny.Session session, Object owner, Object currentValue, EventType eventType); |
Check notice
Code scanning / CodeQL
Useless parameter
| throw new UnsupportedOperationException( "Use generate(Mutiny.Session, Object, Object, EventType) instead" ); | ||
| } | ||
|
|
||
| public abstract Uni<Object> generate(Mutiny.Session session, Object owner, Object currentValue, | ||
| EventType eventType); | ||
| public abstract Uni<?> generate(Mutiny.Session session, Object owner, Object currentValue, EventType eventType); |
Check notice
Code scanning / CodeQL
Useless parameter
| throw new UnsupportedOperationException( "Use generate(Mutiny.Session, Object, Object, EventType) instead" ); | ||
| } | ||
|
|
||
| public abstract Uni<Object> generate(Mutiny.Session session, Object owner, Object currentValue, | ||
| EventType eventType); | ||
| public abstract Uni<?> generate(Mutiny.Session session, Object owner, Object currentValue, EventType eventType); |
Check notice
Code scanning / CodeQL
Useless parameter
DavideD
force-pushed
the
1741-MutinyGenerator
branch
from
175c764 to
ef44883
Compare
DavideD
force-pushed
the
1741-MutinyGenerator
branch
from
ef44883 to
7ba0431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1741
@gavinking Does it make sense? Or am I missing something?
This is the change: d8e08d7