Allow offline startup #2228
Merged
Allow offline startup #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use it to test the dialect selection at start up
This way we can reuse the method even if the tests don't extend BaseReactiveTest
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @ParameterizedTest(name = "Test {0} with " + DIALECT) | ||
| @MethodSource("explicitVersionProperties") | ||
| public void testExplicitVersionWithDialect(String display, Properties dbProperties) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
|
|
||
| @ParameterizedTest(name = "Test {0} with " + JAKARTA_HBM2DDL_DB_NAME) | ||
| @MethodSource("explicitVersionProperties") | ||
| public void testExplicitVersionWithJakartaDbName(String display, Properties dbProperties) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
DavideD
force-pushed
the
2129-Offline-startup
branch
3 times, most recently
from
e220976 to
f4d2f55
Compare
I'm not sure what's the purpose of this test, and why it was working before. But, it doesn't work anymore with the fix for hibernate#2129 because some properties are missing and we are not setting the right credentials. I think it was one of first tests we introduced when we have created the project and obsolete now.
This feature is useful in particular for applications that start up before the DB becomes accessible. It can also be useful for Quarkus, where (part of) startup happens at build time. This achieved by setting the property: ``` hibernate.boot.allow_jdbc_metadata_access = false ```
DavideD
force-pushed
the
2129-Offline-startup
branch
from
f4d2f55 to
403c431
Compare
Hibernate Reactive should be able to start even if there's no database when `hibernate.boot.allow_jdbc_metadata_access = false`.
DavideD
force-pushed
the
2129-Offline-startup
branch
from
403c431 to
18387d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2129