-
Notifications
You must be signed in to change notification settings - Fork 96
Upgrade Hibernate ORM to to 7.0.0.CR2 #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adapt to changes to setParameter() signature
Could you also add the issue to the commit message, please? |
*/ | ||
<P> ReactiveQuery<R> setParameter(int parameter, P argument, BindableType<P> type); | ||
<P> ReactiveQuery<R> setParameter(int parameter, P argument, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameter
This method overrides
ReactiveMutationQuery.setParameter
@@ -128,7 +128,7 @@ | |||
|
|||
<P> ReactiveQuery<R> setParameter(QueryParameter<P> parameter, P argument, Class<P> type); | |||
|
|||
<P> ReactiveQuery<R> setParameter(QueryParameter<P> parameter, P argument, BindableType<P> type); | |||
<P> ReactiveQuery<R> setParameter(QueryParameter<P> parameter, P argument, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameter
This method overrides
ReactiveMutationQuery.setParameter
* | ||
* @apiNote This is used for binding a list of values to an expression | ||
* such as {@code entity.field in (:values)}. | ||
* | ||
* @return {@code this}, for method chaining | ||
*/ | ||
<P> ReactiveQuery<R> setParameterList(String parameter, Collection<? extends P> arguments, BindableType<P> type); | ||
<P> ReactiveQuery<R> setParameterList(String parameter, Collection<? extends P> arguments, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameterList
This method overrides
ReactiveMutationQuery.setParameterList
* | ||
* @apiNote This is used for binding a list of values to an expression | ||
* such as {@code entity.field in (:values)}. | ||
* | ||
* @return {@code this}, for method chaining | ||
*/ | ||
<P> ReactiveQuery<R> setParameterList(String parameter, P[] arguments, BindableType<P> type); | ||
<P> ReactiveQuery<R> setParameterList(String parameter, P[] arguments, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameterList
This method overrides
ReactiveMutationQuery.setParameterList
* | ||
* @apiNote This is used for binding a list of values to an expression | ||
* such as {@code entity.field in (:values)}. | ||
* | ||
* @return {@code this}, for method chaining | ||
*/ | ||
<P> ReactiveQuery<R> setParameterList(int parameter, Collection<? extends P> arguments, BindableType<P> type); | ||
<P> ReactiveQuery<R> setParameterList(int parameter, Collection<? extends P> arguments, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameterList
This method overrides
ReactiveMutationQuery.setParameterList
* | ||
* @apiNote This is used for binding a list of values to an expression | ||
* such as {@code entity.field in (:values)}. | ||
* | ||
* @return {@code this}, for method chaining | ||
*/ | ||
<P> ReactiveQuery<R> setParameterList(int parameter, P[] arguments, BindableType<P> type); | ||
<P> ReactiveQuery<R> setParameterList(int parameter, P[] arguments, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameterList
This method overrides
ReactiveMutationQuery.setParameterList
@@ -314,7 +314,7 @@ | |||
* | |||
* @return {@code this}, for method chaining | |||
*/ | |||
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, Collection<? extends P> arguments, BindableType<P> type); | |||
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, Collection<? extends P> arguments, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameterList
This method overrides
ReactiveMutationQuery.setParameterList
@@ -359,7 +359,7 @@ | |||
* | |||
* @return {@code this}, for method chaining | |||
*/ | |||
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, P[] arguments, BindableType<P> type); | |||
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, P[] arguments, Type<P> type); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ReactiveSelectionQuery.setParameterList
This method overrides
ReactiveMutationQuery.setParameterList
The effect of the commit is perfectly well documented in the commit message. Indeed, there is more information in the commit message than there is in the issue report. How about we focus on concrete ways to make better software than on this sort of process-obsessed checkbox ticking? |
If I'm worrying about issue numbers in commit messages, my attention is on the wrong things, and I'm not focussed on what actually matters. Bureaucracy does harm. |
So melodramatic... but Ok, I'm not going to waist any more time asking this to you. |
Hahah guilty :-) |
adapt to changes to setParameter() signature
Fix #2251