Upgrade database images for testing #2263
Conversation
DavideD
added
testing
DavideD
force-pushed
the
db-upgrades-3.0
branch
2 times, most recently
from
ad21b74 to
c945c18
Compare
| @@ -87,7 +87,7 @@ class PostgreSQLDatabase implements TestableDatabase { | |||
| * TIP: To reuse the same containers across multiple runs, set `testcontainers.reuse.enable=true` in a file located | |||
| * at `$HOME/.testcontainers.properties` (create the file if it does not exist). | |||
| */ | |||
| public static final PostgreSQLContainer<?> postgresql = new PostgreSQLContainer<>( imageName( "postgres", "17.4" ) ) | |||
| public static final PostgreSQLContainer<?> postgresql = new PostgreSQLContainer<>( imageName( "postgres", "17.5" ) ) | |||
There was a problem hiding this comment.
IDK if you'll find it usefull .. but I noticed you are updating DB versions 😃.
In Search we moved the "version" into the docker file:
https://github.com/hibernate/hibernate-search/blob/main/build/container/database/postgresql.Dockerfile
and then the testcontainer uses that docker file to start a db: https://github.com/hibernate/hibernate-search/blob/14a8255a221bfd49b09ad205ab197fe21b572087/util/internal/integrationtest/mapper/orm/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/orm/DatabaseContainer.java#L373
this way you can make dependabot keep your database versions updated:
https://github.com/hibernate/hibernate-search/blob/14a8255a221bfd49b09ad205ab197fe21b572087/.github/dependabot.yml#L167-L183
There was a problem hiding this comment.
Thanks, that's a good hint. I will create an issue for it
Uh oh!
There was an error while loading. Please reload this page.