-
Notifications
You must be signed in to change notification settings - Fork 269
v4 'cachePath' with absolute path #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
All hardcoded paths should be configurable (with default values as fallbacks) in my opinion. |
@nhitchins @DanielRuf feel free to test out #576 and let me know if absolute path for the Highcharts cache works as expected now. |
@jszuminski Working now with absolute path - confirmed! |
Great, thanks for the info! I will close this issue once we merge the PR. |
@jszuminski the PR has been merged for a while now, what are the plans to release the next version including this fix? |
So wait, the changes from the PR #576 have been reversed and put in another PR #597? What happened there? @cvasseng @PaulDalek I really hoped I could finally use the export server with V5 |
Expected behaviour
highcharts.cachePath or HIGHCHARTS_CACHE_PATH env var should allow an absolute path such as '/tmp/.cache'
Actual behaviour
Previously (v3) if the manifest.json file existed in the 'node_modules/highcharts-export-server/.cache' directory but read-only it would log an error and initPool would continue to start. Now initExport throws an error.
Reproduction steps
Set the 'node_modules/highcharts-export-server/.cache/manifest.json' file as read-only and initExport will throw an error.
Ideally just allow cachePath to specify an absolute path and if the manifest.json file exists (and un-changed) then skip writing new manifest
The text was updated successfully, but these errors were encountered: