Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/492-background-color-transparent #499

Merged
merged 1 commit into from
Apr 3, 2024
Merged

bugfix/492-background-color-transparent #499

merged 1 commit into from
Apr 3, 2024

Conversation

jszuminski
Copy link
Contributor

Currently, the fixType method if a file is given with .jpg and not with .jpeg, sets the exportOptions.type = 'png' which then incorrectly performs certain operations. This was a cause for the background being omitted even though we only want to omit backgrounds if the outType == 'png'.

Todo

  • add a unit test for the fixType method - check all the possible conversions

Closes #492.

@jszuminski jszuminski added the bug label Mar 25, 2024
@jszuminski jszuminski requested a review from PaulDalek March 25, 2024 15:02
@jszuminski jszuminski self-assigned this Mar 25, 2024
@jszuminski jszuminski mentioned this pull request Mar 25, 2024
Closed
PaulDalek
PaulDalek approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@PaulDalek PaulDalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@PaulDalek PaulDalek merged commit 82aa6ef into master Apr 3, 2024
@PaulDalek PaulDalek deleted the bugfix/492-background-color-transparent branch April 3, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulDalek PaulDalek PaulDalek approved these changes

Assignees

@jszuminski jszuminski

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export with a fill (background color) of 'none' results in black background
2 participants
@jszuminski @PaulDalek