-
Notifications
You must be signed in to change notification settings - Fork 3.7k
enh(parser) multi-class in a single mode #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(parser) multi-class in a single mode #3081
Conversation
75bc34f
to
8ccffc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving the simplicity needed to add this feature
Co-authored-by: Vladimir Jimenez <[email protected]>
Co-authored-by: Vladimir Jimenez <[email protected]>
Co-authored-by: Vladimir Jimenez <[email protected]>
384132a
to
657521a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty sane to me
Edit: Waittttttt! See #3081 (review)
@@ -206,7 +206,8 @@ type CompiledMode = Omit<Mode, 'contains'> & | |||
endRe: RegExp | |||
illegalRe: RegExp | |||
matcher: any | |||
isCompiled: true | |||
isCompiled: true, | |||
isMultiClass?: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isMultiClass?: boolean, | |
isMultiClass?: true, |
If there's no time it'll ever false
, should the type be true
instead of boolean
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps technically, but that bugs me though i can't explain it. This isn't the same as isCompiled IMHO.
Co-authored-by: Vladimir Jimenez <[email protected]>
…ht.js into multi_class_highlight
Co-authored-by: Vladimir Jimenez <[email protected]>
…ht.js into multi_class_highlight
Resolves #2838.
Changes
Adds multi-class highlighting:
Checklist
CHANGES.md