fix(javascript) correctly highlight 'for await' again #4240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang062
approved these changes
Apr 14, 2025
That's a terrible idea so I don't mind if that edge case isn't covered. |
joshgoebel
approved these changes
Apr 23, 2025
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +15 B View Changes
|
joshgoebel
force-pushed
the
wolfgang42/javascript-fix-for-await
branch
from
e0bcc85 to
d5788d8
Compare
Build Size ReportChanges to minified artifacts in 6 files changedTotal change +9 B View Changes
|
ewwwin
pushed a commit
to ewwwin/highlight.js
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes highlighting for
for await (foo) {}, which had regressed.Closes #4235.
Changes
The
FUNCTION_CALLhighlighting function has a list of excluded keywords; addingawaitthere fixed the highlighting.However, I’m not sure this is the correct fix. I notice there is another special case as well:
highlight.js/src/languages/javascript.js
Lines 557 to 561 in 85b2042
This implies to me that perhaps something in this grammar is in the wrong order, or needs its relevance adjusted, but that seems like a much bigger change and I’m having a hard time figuring out what it would need to look like.
Also, it is technically possible (if very confusing) to have a function called
await, and this would be highlighted incorrectly:Checklist
CHANGES.md