Also send ping when no message has been read for the keep alive time #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtSilvio
force-pushed
the
improvement/ping-qos0
branch
from
4932452 to
9009cb4
Compare
SgtSilvio
force-pushed
the
improvement/ping-qos0
branch
from
9009cb4 to
6ab0e17
Compare
MicWalter
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ping should detect all half open connections.
When the client only sends QoS 0 messages and does not receive messages, no ping is currently sent as there is write activity. Instead a ping should be sent to force the server to send a pingresp.
Changes