New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc cleanup #371

Merged

SgtSilvio merged 6 commits into develop from javadoc-cleanup

Feb 24, 2020

Member

SgtSilvio commented Feb 14, 2020 •

edited

Loading

Motivation
Javadoc for reason code enums is missing.

Changes

Added javadoc for reason code enums
Exclude internal package from javadoc

cla-bot bot added the cla-signed label

SgtSilvio self-assigned this

SgtSilvio added the cleanup label

SgtSilvio added this to the 1.1.4 milestone

SgtSilvio requested review from a user and gitseti

February 19, 2020 13:09

ghost suggested changes

View reviewed changes

src/main/java/com/hivemq/client/mqtt/mqtt5/message/connect/connack/Mqtt5ConnAckReasonCode.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/disconnect/Mqtt5DisconnectReasonCode.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/publish/Mqtt5PayloadFormatIndicator.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/publish/Mqtt5PayloadFormatIndicator.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt3/message/connect/connack/Mqtt3ConnAckReturnCode.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/publish/pubrec/Mqtt5PubRecReasonCode.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/Mqtt5RetainHandling.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/Mqtt5RetainHandling.java Outdated Show resolved Hide resolved

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/suback/Mqtt5SubAckReasonCode.java Outdated Show resolved Hide resolved

.../java/com/hivemq/client/mqtt/mqtt5/message/unsubscribe/unsuback/Mqtt5UnsubAckReasonCode.java Outdated Show resolved Hide resolved

SgtSilvio commented

View reviewed changes

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/Mqtt5RetainHandling.java Outdated Show resolved Hide resolved

SgtSilvio commented

View reviewed changes

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/Mqtt5RetainHandling.java Outdated Show resolved Hide resolved

SgtSilvio commented

View reviewed changes

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/Mqtt5RetainHandling.java Outdated Show resolved Hide resolved

SgtSilvio requested a review from a user

February 19, 2020 18:31

SgtSilvio commented

View reviewed changes

src/main/java/com/hivemq/client/mqtt/mqtt5/message/connect/connack/Mqtt5ConnAckReasonCode.java Outdated Show resolved Hide resolved

SgtSilvio commented

View reviewed changes

src/main/java/com/hivemq/client/mqtt/mqtt5/message/publish/pubcomp/Mqtt5PubCompReasonCode.java Outdated Show resolved Hide resolved

ghost approved these changes

View reviewed changes

SgtSilvio and others added 6 commits

February 24, 2020 10:09


          Small cleanups

5b75485


          Added javadoc for reason code enums

c5f499d


          Exclude internal package from javadoc


          Apply suggestions from code review

3d2fdde

Co-Authored-By: LukasHiveMQ <[email protected]>


          Apply suggestions from code review


          Apply suggestions from code review

5d35396

SgtSilvio force-pushed the javadoc-cleanup branch from c0b3006 to 5d35396 Compare

February 24, 2020 09:09

SgtSilvio merged commit 906b52a into develop

SgtSilvio deleted the javadoc-cleanup branch

February 24, 2020 09:29

SgtSilvio added improvement and removed cleanup labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed improvement