Reimplement operator apps, operator splits, and "placeholder shorthand" lambdas #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hkmc2/shared/src/main/scala/hkmc2/syntax/Parser.scala # hkmc2/shared/src/test/mlscript/HkScratch.mls # hkmc2/shared/src/test/mlscript/backlog/MultilineExpressions.mls # hkmc2/shared/src/test/mlscript/backlog/UCS.mls # hkmc2/shared/src/test/mlscript/handlers/Debugging.mls # hkmc2/shared/src/test/mlscript/nofib/clausify.mls # hkmc2/shared/src/test/mlscript/nofib/last-piece.mls # hkmc2/shared/src/test/mlscript/nofib/mate.mls # hkmc2/shared/src/test/mlscript/nofib/minimax.mls # hkmc2/shared/src/test/mlscript/nofib/pretty.mls # hkmc2/shared/src/test/mlscript/nofib/treejoin.mls # hkmc2/shared/src/test/mlscript/ucs/examples/BinarySearchTree.mls # hkmc2/shared/src/test/mlscript/ucs/papers/OperatorSplit.mls
# Conflicts: # hkmc2/shared/src/main/scala/hkmc2/semantics/Elaborator.scala # hkmc2/shared/src/main/scala/hkmc2/syntax/Parser.scala # hkmc2/shared/src/main/scala/hkmc2/syntax/Tree.scala # hkmc2/shared/src/test/mlscript-compile/Iter.mjs # hkmc2/shared/src/test/mlscript-compile/Predef.mjs # hkmc2/shared/src/test/mlscript/backlog/ToTriage.mls # hkmc2/shared/src/test/mlscript/basics/AppOp.mls # hkmc2/shared/src/test/mlscript/basics/MiscArrayTests.mls # hkmc2/shared/src/test/mlscript/codegen/FunnyOpen.mls # hkmc2/shared/src/test/mlscript/codegen/Juxtapositions.mls # hkmc2/shared/src/test/mlscript/codegen/OptMatch.mls # hkmc2/shared/src/test/mlscript/llir/Classes.mls # hkmc2/shared/src/test/mlscript/llir/ControlFlow.mls # hkmc2/shared/src/test/mlscript/llir/HigherOrder.mls # hkmc2/shared/src/test/mlscript/llir/Lazy.mls # hkmc2/shared/src/test/mlscript/llir/LazyCycle.mls # hkmc2/shared/src/test/mlscript/llir/Method.mls # hkmc2/shared/src/test/mlscript/llir/Tuple.mls # hkmc2/shared/src/test/mlscript/std/PredefTest.mls
This reverts commit 5aef5e9.
LPTK
commented
May 12, 2025
# Conflicts: # hkmc2/shared/src/main/scala/hkmc2/syntax/Keyword.scala # hkmc2/shared/src/main/scala/hkmc2/syntax/Parser.scala # hkmc2/shared/src/test/mlscript/backlog/ToTriage.mls # hkmc2/shared/src/test/mlscript/backlog/UCS.mls # hkmc2/shared/src/test/mlscript/basics/Puns.mls # hkmc2/shared/src/test/mlscript/codegen/PartialApps.mls
|
@chengluyu I think I'm done with my changes. Could you please review them and also review your own changes? |
chengluyu
requested changes
May 24, 2025
There was a problem hiding this comment.
Nice PR! I’ve left a few minor suggestions and questions.
I’m glad to see that the syntax for operator and newline has been determined. Also, the parser can now handle operator splits in a better way.
This PR has also eliminated many parse errors, making the parser more robust. I think like I can now update the parser used by the VSCode extension.
(Let's merge this PR so that I can resolve the conflicts in my PR. 😁)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chengluyu This is the WIP of my changes. Can you please look into updating the UCS and pattern compilation implementations?