Refactor device components #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 3b7b34b on chore-refactor-device-components into * on dev*. |
|
I have tested it with my custom switch platform. It works well, I only had to change a few lines of code to get it working (switch device_discovery with setup_platform and have the devices added by the callback function). |
balloob
force-pushed
the
chore-refactor-device-components
branch
from
fb70dff to
0004700
Compare
|
Just added some code that makes it backwards compatible and issue a warning that you should update the component: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a common base for the four components that handle devices: thermostat, light, switch, sensor.