This repository was archived by the owner on Aug 22, 2024. It is now read-only.
Material theme and remove flashbar #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
hossain-khan
commented
Apr 25, 2019
hossain-khan
commented
…ue to issue reported below. aritraroy/Flashbar#8 This is possible because of simple use case for this demo app. For other complex app, this solution may not be feasible as flashbar has far more features than just bottom docked bar.
``` Fragment not instantiatable ../../src/main/java/com/hossainkhan/android/demo/ui/dialog/LayoutInfoDialog.kt:35: Avoid non-default constructors in fragments: use a default constructor plus Fragment#setArguments(Bundle) instead 32 /** 33 * Bottom sheet dialog to show layout information. 34 */ 35 class LayoutInfoDialog( 36 private val title: String = "", 37 private val desciption: String = "", 38 private val previewXmlListener: (() -> Unit)? = null ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.