Skip to content

feat: Add itemLabelProps #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amhinson
Copy link
Contributor

This PR adds itemLabelProps to allow developers to pass props directly to the Text component inside the item.

This could address issues like #460:

itemLabelProps={{
    numberOfLines: 1
}}

@hossein-zare
Copy link
Owner

Thanks for the PR.

@amhinson
Copy link
Contributor Author

Any update on this?

@smbkr
Copy link

smbkr commented Nov 9, 2022

Hey @hossein-zare is there anything outstanding on this PR that needs addressing? I'm experiencing the same problem as #460 and it looks like this change is a good solution.

@hossein-zare hossein-zare merged commit d644bef into hossein-zare:dev-5.x Nov 9, 2022
@hossein-zare
Copy link
Owner

hossein-zare commented Nov 9, 2022

Hello again, @amhinson @smbkr

is there anything outstanding on this PR that needs addressing?

Nope, Just the things happening in my country (Iran) kept me away from working on projects.
Git is blocked for some stupid reason we don't know and so are almost all VPNs and Proxies.

I'll publish a new version as soon as possible.

@hossein-zare hossein-zare added the documentation Improvements or additions to documentation label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants