Skip to content

feat: Move all Binder config files to binder directory #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewfeickert
Copy link
Contributor

Instructions

Thanks for contributing! ❤️

Keep in mind that lesson maintainers are volunteers and it may take them some time to respond to your contribution.
To ensure that the right people get notified, you can tag some of the last contributors with @githubname.

Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact the HSF training convenors (contacts here).

You may delete these instructions from your pull request.

- HSF Training

* Add binder directory to make it clear to Binder where to find files.
* Move requirements.txt to binder/ and then symlink back to top level for
  user ease of use.
* Add binder/runtime.txt to specify a Python runtime of Python 3.10.
@welcome
Copy link

welcome bot commented Sep 13, 2022

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

@matthewfeickert
Copy link
Contributor Author

@klieret this is ready for review. This can provide Binder stability by specifying more of the runtime.

@amangoel185
Copy link
Member

@matthewfeickert, would it be better to update the Binder (and SWAN) link too? Currently points to @plttraining (https://mybinder.org/v2/gh/plttraining/hsf_matplotlib_notebooks/main) since it was ported to @hsf-training from there.

They work well already though!

@matthewfeickert
Copy link
Contributor Author

@amangoel185 Done now with

git grep --name-only "plttraining" | xargs sed -i "s/plttraining/hsf-training/g"

so should have gotten everything.

@amangoel185
Copy link
Member

Looks great, thank you! :)

@amangoel185 amangoel185 merged commit ea0fdce into hsf-training:main Sep 13, 2022
@welcome
Copy link

welcome bot commented Sep 13, 2022

Congrats on merging your first pull request 🎉! We greatly appreciate it.
You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you are also eligible to add yourself there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants