Skip to content

feat: use cosmiconfig #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

nschonni
Copy link
Contributor

Short description of what this resolves:
Taking a kick at #126 to better handle malformed configs, and support for other config formats.

Haven't figured how to properly throw/test this yet

Proposed changes:

@github-actions github-actions bot added cli Relates to HTMLHint's command-line interface dependencies Pull requests that update a dependency file test labels Dec 16, 2021
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Feb 17, 2022
@nschonni nschonni removed the bot:stale Issue marked as stale because there was no activity label Feb 17, 2022
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Apr 18, 2022
@nschonni nschonni added keep-unstale The issue will not be marked as stale by the stale-bot and removed bot:stale Issue marked as stale because there was no activity labels Apr 18, 2022
@MindTooth
Copy link

Could this be tweaked to also include support for htmlhint.config.js?

@Kristinita
Copy link

Are there any chances that this feature will be implemented to HTMLHint?

Thanks.

@htmlhint htmlhint deleted a comment from stale bot Jun 17, 2024
@htmlhint htmlhint deleted a comment from stale bot Jun 6, 2025
@coliff
Copy link
Member

coliff commented Jun 6, 2025

This PR was made many years ago and has many merge conflicts.. (the codebase has changed a lot since!) so I think it makes sense to close this for now... We would like to add cosmiconfig I think but I think it'll be done in a new PR.

@coliff coliff closed this Jun 6, 2025
@nschonni nschonni deleted the cosmiconfig-setup branch June 6, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Relates to HTMLHint's command-line interface dependencies Pull requests that update a dependency file keep-unstale The issue will not be marked as stale by the stale-bot test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants