Add support for setting the host in the executable #268
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds useful, nice pull request! |
|
Can you do just a little style change?, just use a positive verification Thank you! |
|
ok, looks good to me. |
indexzero
added a commit
that referenced
this pull request
Jul 22, 2012
Add support for setting the host in the executable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for a host to be set with the node-http-proxy executable. It adds the
--hostargument meaning you can doMy use case is that I have a server that has the following IP addresses assigned to it
Port 80 on 192.168.3.5 is used by Nginx and I want to use port 80 on 192.168.3.37 for node-http-proxy. Without the patch the executable binds to INADDR_ANY and because Nginx is already listening to port 192.168.3.5:80 I get