Skip to content

do not modify the query string #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2014

Conversation

richardkazuomiller
Copy link
Contributor

Fix the issue of multiple consecutive slashes being replaced by a single slash referenced in #703 and #710 by separating the query string from the rest of the URL in common.urlJoin. I tried removing trailing slashes as suggested by @yulesyu in #703 but that still caused issues if the query string ended in //

@indexzero
Copy link
Member

Except for minor style things this lgtm @jcrugzz. It even has a new test 👍

@jcrugzz
Copy link
Contributor

jcrugzz commented Nov 11, 2014

@richardkazuomiller this is a good start. I think this function still needs some more love to handle the other edge cases but thank you very much! I'll merge and fix the stylings. Just not that we like less var statements ;)

jcrugzz added a commit that referenced this pull request Nov 11, 2014
@jcrugzz jcrugzz merged commit eb95660 into http-party:master Nov 11, 2014
@richardkazuomiller
Copy link
Contributor Author

Thanks! I'm a long time node-http-proxy user and happy to finally be able to contribute. I checked your last commit I'll keep the var thing in mind for next time (^_^)

@indexzero
Copy link
Member

User becomes contributor 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants