Make several features non-default #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're in the 0.17 beta, we can make breaking API changes, such as making previously default features non-default. Leave `h1-server` on by default, since tide isn't an HTTP server without it. Disable all other optional features by default, and let the user opt into them as needed.
joshtriplett
force-pushed
the
non-default-features
branch
from
49ff463 to
81db3d9
Compare
|
I suspect there must be more docs adjustments to be made? |
|
On Mon, May 09, 2022 at 05:56:18PM -0700, Jeremiah Senkpiel wrote:
I suspect there must be more docs adjustments to be made?
I dug through the documentation and didn't find any other cases that
depended on these features being enabled by default.
|
Fishrock123
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're in the 0.17 beta, we can make breaking API changes, such as
making previously default features non-default.
Leave
h1-serveron by default, since tide isn't an HTTP server withoutit. Disable all other optional features by default, and let the user opt
into them as needed.