Add translation store with support for English and French #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry I don't think we will be merging this. It's quite a big change and I don't think using a store is the best way for this, we want to make sure it works with SSR for example. We probably want to use a tool like paraglide if we end up supporting i18n. It also makes the codebase quite a bit more complex and since there's been little requests for translations atm (this issue on the topic doesn't have a lot of reactions) I don't think we'll be spending time on this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code structure for UI translation
Add French translation of the UI
Select your preferred language in the application settings.
Browser language can be used if browser language is available.
Thanks to the
DEFAULT_LANGUAGEenvironment variable, you can also define your application's default language preference. This can be a language already installed (e.g. 'en' or 'fr').Also takes into account the 'browser' value to set the default language on the user's browser.