Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update HF Token on Fast GPU Model Tests #10570

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[CI] Update HF Token on Fast GPU Model Tests #10570

merged 1 commit into from
Jan 14, 2025

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Jan 14, 2025

What does this PR do?

Missed this token when opening: #10568

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul January 14, 2025 08:31
@@ -137,7 +137,7 @@ jobs:

- name: Run PyTorch CUDA tests
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
HF_TOKEN: ${{ secrets.DIFFUSERS_HF_HUB_READ_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the push_tests we don't run the big checkpoint related stuff no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't. Just Fast GPU tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not a blocker but I think it can be removed then no as we don't need the token in these tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the single file model tests we check loading and config with a real checkpoint since it's challenging to create dummy checkpoints for single file models.

Once we work out single file serialization we can remove.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. Let's go!

@DN6 DN6 merged commit be62c85 into main Jan 14, 2025
11 checks passed
DN6 added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants