Skip to content

SDXL ControlNet Union pipelines, make control_image argument immutible #10663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

Teriks
Copy link
Contributor

@Teriks Teriks commented Jan 27, 2025

when control_image is passed a list, __call__
modifies its content, since it is pass by reference the list passed by the caller gets its content modified unexpectedly

make a copy at method intro so this does not happen

What does this PR do?

Fixes # (issue)

Before submitting

Who can review?

@yiyixuxu @asomoza

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

when this argument is passed a list, __call__
modifies its content, since it is pass by reference
the list passed by the caller gets its content
modified unexpectedly

make a copy at method intro so this does not happen
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Teriks

@yiyixuxu yiyixuxu merged commit e89ab5b into huggingface:main Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants