-
Notifications
You must be signed in to change notification settings - Fork 6k
Refactor OmniGen #10771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor OmniGen #10771
Conversation
pull the latest code
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
update to latest version
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thank you!
callback_on_step_end: Optional[Callable[[int, int, Dict], None]] = None, | ||
callback_on_step_end_tensor_inputs: List[str] = ["latents"], | ||
max_sequence_length: int = 120000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is not used, but let's confirm with the author if it's intended to be used or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This argument is simply copied from other pipelines, but is not used in OmniGen.
@staoxiao can you take a look to see if the changes are ok? |
Thanks for the heads-up, Aryan! Appreciate it. I will wait for this before to get merged before starting the LoRA support. |
@a-r-r-o-w @yiyixuxu , thanks for refactoring. I think these changes are ok. |
Thanks for the review @staoxiao! Will merge once CI is green |
Refactors OmniGen added in #10148.
I haven't tested all supported usecases extensively, but I believe the changes should be okay since they did not alter any existing logic (except for RoPE).
The summary of changes are:
apply_rotary_emb
function, we use the Diffusers one