Skip to content

Apply Occam's Razor in position embedding calculation #11562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented May 15, 2025

Eliminate unnecessary indexing in the calculation of frequency values for the position embedding, simplifying the code.
Context: #11518 (comment)

@a-r-r-o-w @yiyixuxu

@tolgacangoz tolgacangoz changed the title Remove redundant indexing in position embedding calculation Apply Occam's Razor in position embedding calculation May 15, 2025
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu May 15, 2025 16:26
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants