-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix bug when variant
and safetensor
file does not match
#11587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR fixes bug under |
@a-r-r-o-w @DN6 , pls help review, thx. |
@bot /style |
Style fixes have been applied. View the workflow run here. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Thanks @kaixuanliu! I think we would need to add the variant check when there are no component folders as well. if not components:
return any(".safetensors" in filename for filename in filenames) And I think the changes will break the current
|
@DN6 , Hi, thanks for your advice. Have updated the code and test cases |
Signed-off-by: Liu, Kaixuan <[email protected]>
Signed-off-by: Liu, Kaixuan <[email protected]>
Signed-off-by: Liu, Kaixuan <[email protected]>
Signed-off-by: Liu, Kaixuan <[email protected]>
@bot /style |
1 similar comment
@bot /style |
Style fixes have been applied. View the workflow run here. |
Signed-off-by: Liu, Kaixuan <[email protected]>
Signed-off-by: Liu, Kaixuan <[email protected]>
@DN6 Hi, I have checked all the CI tests offline. Can you help trigger the CI workflow again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you 🙏🏽 @kaixuanliu
No description provided.