Skip to content

Make SDXL treat the "optional" components as really optional #11610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ppbrown
Copy link

@ppbrown ppbrown commented May 25, 2025

What does this PR do?

This makes the "optional" text modules in StableDiffusionXLPipeline actually function as optional, instead of mandatory.
(There was already code present that suggests you can optionally skip modules: unfortunately, the code does not actually work that way, so this fixes the unfiled bug)

The patch can be verified by running the code mentioned in the target model in the README.md at
https://huggingface.co/opendiffusionai/sdxlone

Before submitting

Who can review?

Core library:

@ppbrown ppbrown marked this pull request as ready for review May 26, 2025 17:31
@asomoza
Copy link
Member

asomoza commented May 27, 2025

@ppbrown thanks for your contribution.

We usually only add additional code to the official pipelines and the core when there's a fully working and released model that it's also popular, to avoid adding more complexity and making it a huge library with unused models.

For what I can see in your model repo:

So, I created this version to experimentally prove the better way.

and in the other model there is this part:

This raw version of the model seems to work great with 3-5 word prompts... but then decays after that. So I'm working on a finetuned version.

both texts suggest that this is just and experiment that needs more finetuning, also it's not that popular right now.

I suggest that we add this as a community pipeline for the moment so people can test your model and we can see then how this goes for the community, also it would make it a lot faster to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants