Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Safetensors] Make safetensors the default way of saving weights #4235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Safetensors] Make safetensors the default way of saving weights #4235
Changes from all commits
690f8a6
d366af4
35273fd
948db23
f663696
e513a41
5043f07
f63f7a6
7e63f22
3f9a7bb
48a3d55
848e982
9c456b1
ed15f87
0954946
981fbcd
1dd3441
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
save_lora_weights()
havesafe_serialization
set to True default? Otherwise, this will fail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we don't need to explicitly specify the
weight_name
actually since the naming is in thediffusers
format.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safe_serialization
defaults toTrue
in theLoraLoaderMixin
diffusers/src/diffusers/loaders.py
Line 1418 in 1dd3441
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding,
weight_name
. Not setting it while saving is fine, however, loading looks like it needs a path to the weightsdiffusers/src/diffusers/loaders.py
Line 906 in 1dd3441
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you only need
pipeline.load_lora_weights(args.output_dir)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Cool.