-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Remove code snippets containing is_safetensors_available()
#4521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation is not available anymore as the PR was closed or merged. |
The summary in the PR description above is the summary from Need some help understanding the current |
Hi @chiral-carbon PR looks good. I'd like to update/add some tests to this PR. Can add me as a collaborator to your fork so that I can commit them? Alternatively, I can create another with the test changes that you can merge into your branch. LMK what works for you 👍🏽 |
Thanks @DN6! I think I would like to merge your test commits from your own fork. If that is a longer process though I will directly add you as collaborator. |
@chiral-carbon Could you merge the commits from |
@DN6 let me know if I merged the commits correctly. I'll look into why one test still fails |
@chiral-carbon Pushed up a fix for that test. If you could merge it from the same branch I think we should be good |
it works @DN6, thanks! I was stuck on the logic in the last tests so this helps me understand too |
is_safetensors_available()
is_safetensors_available()
Hi @chiral-carbon requesting one last small change. I think we can get rid of these lines in the test. We don't need them anymore. diffusers/tests/models/test_modeling_common.py Lines 63 to 65 in ac1580a
|
ac1580a
to
62ab236
Compare
Great job @chiral-carbon 🙌🏽 |
@DN6 thanks for all your help! |
…face#4521) * [WIP] Remove code snippets containing `is_safetensors_available()` * Modifying `import_utils.py` * update pipeline tests for safetensor default * fix test related to cached requests * address import nits --------- Co-authored-by: Dhruv Nair <[email protected]>
…face#4521) * [WIP] Remove code snippets containing `is_safetensors_available()` * Modifying `import_utils.py` * update pipeline tests for safetensor default * fix test related to cached requests * address import nits --------- Co-authored-by: Dhruv Nair <[email protected]>
What does this PR do?
Fixes #4243
Some tests failing on running
make test
, since I did not add my own tests.make test
summary:Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten @DN6