Skip to content

[wip] sdxl inpainting #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

williamberman
Copy link
Contributor

No description provided.

@williamberman williamberman marked this pull request as draft August 24, 2023 00:35
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@bghira
Copy link
Contributor

bghira commented Aug 28, 2023

was this intended on going into the text to image script? it seems like a substantial change and makes no effort for backwards compatibility between these two very different training approaches.

are you planning on including offset noise and v_prediction sample prediction?

was there a specific reason that the final validation output was removed?

it also looks like the epoch count is hardcoded, and when resuming from ckpt, information on how to resume is discarded.

the wds train_dataset variable population looks like it discarded all of the embed/latent precompute logic, which is likely something you'll want to fit back in.

@williamberman
Copy link
Contributor Author

@bghira this is just a checkpoint we're working on that we pushed the wip script to github to colab on a bit. If we decide to push a script to diffusers source, it won't be as adhoc as this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants