Update export to video to support new tensor_to_vid function in video pipelines
#6715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Jan 26, 2024
| @@ -125,7 +125,10 @@ def export_to_video( | |||
| if output_video_path is None: | |||
| output_video_path = tempfile.NamedTemporaryFile(suffix=".mp4").name | |||
|
|
|||
| if isinstance(video_frames[0], PIL.Image.Image): | |||
| if isinstance(video_frames[0], np.ndarray): | |||
There was a problem hiding this comment.
Can't we use the numpy_to_pil() method from processor?
There was a problem hiding this comment.
We would need to pass in the processor instance into export_to_video though?
There was a problem hiding this comment.
Ah yes. I am okay as is then.
dg845
pushed a commit
to dg845/diffusers
that referenced
this pull request
Feb 2, 2024
…eo pipelines (huggingface#6715) update
Closed
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…eo pipelines (huggingface#6715) update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recently merged #6626 which uses a new
tensor_to_vidfunction to output video frames. Frames in thenpformat are scaled to 0-1, which is causing an issue withexport_to_videosince it expects numpy arrays scaled between 0-255.This PR:
export_to_videoto see if a numpy array has been passed in and scales it to 0-255 before writing to video.Fixes # (issue)
#6681
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.