Create branch if missing in hugginface-cli upload #1857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
…com:huggingface/huggingface_hub into 1841-create-branch-if-missing-in-cli-upload
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
===========================================
+ Coverage 48.47% 82.46% +33.98%
===========================================
Files 64 64
Lines 7795 7801 +6
===========================================
+ Hits 3779 6433 +2654
+ Misses 4016 1368 -2648 ☔ View full report in Codecov by Sentry. |
LysandreJik
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Thanks @Wauplin, this looks good to me and makes sense form an API perspective
|
Thanks for the quick review @LysandreJik! |
|
API makes sense to me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1841 and #1657 cc @AlpinDale
With this PR, running
huggingface-cli upload ... ... --revision=my-branchwill automatically create the branch if it does not exist yet. I added some tests and adapted the docs.Note:
--create-pr