-
Notifications
You must be signed in to change notification settings - Fork 712
(misc) Deprecate some hf-inference specific features (wait-for-model header, can't override model's task, get_model_status, list_deployed_models) #2851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for taking care of this! @Wauplin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about
deprecate sentence-similarity (use feature-extraction instead)
given it'll still be a task on hf.co/tasks for the foreseeable future.
Personally i wouldn't remove it 🤷
Everything else LGTM
Ok I added it back in 4218f8d but removed the ability to call |
yes, perfect imo |
…:huggingface/huggingface_hub into deprecate-hf-inference-specific-features
Does this change mean that other clients should also stop using |
Hey @SpecLad ,
Yes it does. You can send it but it won't have any effect anymore
Thanks for reporting. We are currently revamping these docs (see huggingface/hub-docs#1652) and will remove it from there. |
In this PR:
deprecate=> not deprecated after all (see comment)sentence-similarity
(usefeature-extraction
instead)sentence-similarity
, eitherfeature-extraction
but not bothget_model_status
(will be replaced byHfApi.model_info
list_deployed_models
(will be replaced byHfApi.list_models
)X-wait-for-model
anymore=> the http 503 thingy is a breaking change but mostly due to the fact that forbidding cold starts in Inference API is a breaking change => so not a problem
Related: