-
Notifications
You must be signed in to change notification settings - Fork 712
Do not fetch /preupload if already done in upload-large-folder #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fetch /preupload if already done in upload-large-folder #3100
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly the changes I was going to commit 😄
thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cood catch! I completely missed that we weren’t storing the upload modes too. This is a much more complete fix, thank you!
I tested it locally as well, it works as expected ✅
status.nb_workers_get_upload_mode += 1 | ||
logger.debug("Job: get upload mode (>10 files ready)") | ||
return (WorkerJob.GET_UPLOAD_MODE, _get_n(status.queue_get_upload_mode, status.target_chunk())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need target_chunk()
function anymore, right? I'm a bit confused, I don't recall exactly why we had it in the first place in #3016, the dynamic sizing was only meant for the commit job and it was not strictly necessary for the get upload mode job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, we reviewed #3016 a bit too quickly 🙈 target_chunk
must be used for commit chunks (but not done at the moment). Let's fix this in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in ce1e35d
I'm merging this, thanks again @Wauplin for the fix! |
Originally from @Kakulukian on slack (private):