Add support for different TFDS BuilderConfig
s
#1239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now a user can't use a TFDS
BuilderConfig
different than the default one: the current parser assumes that the dataset is in the form{torch,tfds,...}/dataset
, while in the case of TFDS datasets it can betfds/dataset/builder-type
, e.g.tfds/diabetic_retinopathy_detection/btgraham-300
(as in here).This PR fixes this by taking whatever is split at line 10 after the first element (which is the source of the dataset) and joining it again with
/
.In the case there is just one
/
, thenname[1:]
will contain just one element, e.g., if we passtfds/imagenet2012
, thenname[1:] == ["imagenet2012"]
and"/".join(name[1:]) == "imagenet2012"
, leaving the current behavior unchanged. If instead there are multiple/
(e.g."tfds/diabetic_retinopathy_detection/btgraham-300"
), thenname[1:] == ["diabetic_retinopathy_detection", "btgraham-300"]
, and"/".join(name[1:]) == "diabetic_retinopathy_detection/btgraham-300"
, which is compatible with thetfds
format.