feat: paged attention v2 #1183
Merged
feat: paged attention v2 #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi OlivierDehaene, I have a question about this and the flash attention kernel. |
|
@dongs0104, it's mainly to keep the final docker images small enough. Since we only use the attention/paged attention kernels, we do not want to bundle the rest as the image is already big. For users that do not rely on the docker image, installing through pip is 100% fine. |
Closed
|
@OlivierDehaene does paged attention v2 work by default then? no additional flags or installs required? Thanks and thanks for your work on it. |
|
Yes, as long as you use ghcr.io/huggingface/text-generation-inference:sha-12590fd or ulterior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.