Skip to content

refactored beam search according to torch implementation #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Mar 5, 2020

1:1 translation of PR #3135 from Pytorch to TF.

@patrickvonplaten
Copy link
Contributor Author

good to merge for me

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #3148 into master will decrease coverage by 1.04%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   78.03%   76.98%   -1.05%     
==========================================
  Files          98       98              
  Lines       16573    16583      +10     
==========================================
- Hits        12932    12766     -166     
- Misses       3641     3817     +176
Impacted Files Coverage Δ
src/transformers/modeling_tf_utils.py 91.47% <95.83%> (-1.95%) ⬇️
src/transformers/modeling_tf_pytorch_utils.py 8.72% <0%> (-81.21%) ⬇️
src/transformers/modeling_roberta.py 85.71% <0%> (-10%) ⬇️
src/transformers/modeling_xlnet.py 73.48% <0%> (-2.3%) ⬇️
src/transformers/modeling_ctrl.py 96% <0%> (-2.23%) ⬇️
src/transformers/modeling_openai.py 80.2% <0%> (-1.35%) ⬇️
src/transformers/modeling_utils.py 94.56% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0001d05...2861c9d. Read the comment docs.

@patrickvonplaten patrickvonplaten force-pushed the refactoring_beam_search_for_tf_2 branch from 2861c9d to 9362eb4 Compare March 5, 2020 23:46
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me as well, merging

@thomwolf thomwolf merged commit 0416d43 into huggingface:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants