Skip to content

Add Idefics2 Fast ImageProcessor #37053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

sushmanthreddy
Copy link
Contributor

@sushmanthreddy sushmanthreddy commented Mar 27, 2025

related #36978

@github-actions github-actions bot marked this pull request as draft March 27, 2025 19:22
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@sushmanthreddy sushmanthreddy marked this pull request as ready for review March 28, 2025 10:01
@github-actions github-actions bot requested review from ydshieh and yonigozlan March 28, 2025 10:02
@sushmanthreddy
Copy link
Contributor Author

@yonigozlan @Rocketknight1 if u get chance pls take look for this PR

@Rocketknight1
Copy link
Member

cc @yonigozlan @qubvel

@qubvel qubvel changed the title add the Ideficsfastimageprocessor Add the Idefics Fast ImageProcessor Mar 28, 2025
@qubvel qubvel changed the title Add the Idefics Fast ImageProcessor Add Idefics2 Fast ImageProcessor Mar 28, 2025
@qubvel
Copy link
Member

qubvel commented Mar 28, 2025

Hi @sushmanthreddy, huge thanks for working on the PR! It would be super helpful for us if you could make sure quality tests and related image-processor tests all pass before the initial review 🤗

@sushmanthreddy
Copy link
Contributor Author

@qubvel I have kept commit for the quality checks here .

and below are screenshots of the tests passing screenshot of idefics2 model

Screenshot 2025-03-28 at 8 55 42 PM Screenshot 2025-03-28 at 8 56 09 PM

@sushmanthreddy
Copy link
Contributor Author

@qubvel I have run quality checks in my local machine ,they are running fine but here cli they are failing dont knew the reason, can someone pls help me?

@yonigozlan
Copy link
Member

@sushmanthreddy there might be something wrong in your .vscode/settings.json config or ruff config? Is your Ruff: Line Length set to 119 in the vscode settings?

@qubvel
Copy link
Member

qubvel commented Apr 1, 2025

BTW, the ruff was updated last week, make sure you have ruff==0.11.2, you can simply update as follows:

pip install -U ruff==0.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants