Skip to content

Commit 9aa9392

Browse files
authored
Merge pull request kubernetes-csi#761 from humblec/trivvy
test: add codespell github workflow and templates for issues/RFEs.
2 parents 058f6a7 + 10e3a87 commit 9aa9392

File tree

8 files changed

+78
-4
lines changed

8 files changed

+78
-4
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
---
2+
name: Bug Report
3+
about: Create a report to help us improve this project
4+
5+
---
6+
7+
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
8+
-->
9+
10+
11+
**What happened**:
12+
13+
**What you expected to happen**:
14+
15+
**How to reproduce it**:
16+
17+
**Anything else we need to know?**:
18+
19+
**Environment**:
20+
- Driver version:
21+
- Kubernetes version (use `kubectl version`):
22+
- OS (e.g. from /etc/os-release):
23+
- Kernel (e.g. `uname -a`):
24+
- Install tools:
25+
- Others:

.github/ISSUE_TEMPLATE/enhancement.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
name: Enhancement Request
3+
about: Suggest an idea for this project
4+
5+
---
6+
7+
8+
**Is your feature request related to a problem?/Why is this needed**
9+
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
10+
11+
**Describe the solution you'd like in detail**
12+
<!-- A clear and concise description of what you want to happen. -->
13+
14+
**Describe alternatives you've considered**
15+
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
16+
17+
**Additional context**
18+
<!-- Add any other context or screenshots about the feature request here. -->

.github/ISSUE_TEMPLATE/support.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
name: Support Request
3+
about: Ask questions about this project
4+
5+
---
6+
7+
<!--
8+
STOP -- PLEASE READ!
9+
10+
GitHub is not the right place for support requests.
11+
12+
If you're looking for help, post your question on the [Kubernetes Slack ](http://slack.k8s.io/) #sig-storage Channel.
13+
14+
If the matter is security related, please disclose it privately via https://kubernetes.io/security/.
15+
-->
16+

.github/workflows/codespell.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# GitHub Action to automate the identification of common misspellings in text files.
2+
# https://github.com/codespell-project/actions-codespell
3+
# https://github.com/codespell-project/codespell
4+
name: codespell
5+
on: [push, pull_request]
6+
jobs:
7+
codespell:
8+
name: Check for spelling errors
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v2
12+
- uses: codespell-project/actions-codespell@master
13+
with:
14+
check_filenames: true
15+
skip: ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh

CHANGELOG/CHANGELOG-1.4.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ In this case, Provisioner will use PVC requested size as PV size rather than 0 b
2222
- Fixed potential leak of volumes after CSI driver timeouts. ([#312](https://github.com/kubernetes-csi/external-provisioner/pull/312), [@jsafrane](https://github.com/jsafrane))
2323
- Fixes issue where provisioner provisions volumes for in-tree PVC's which have not been migrated ([#341](https://github.com/kubernetes-csi/external-provisioner/pull/341), [@davidz627](https://github.com/davidz627))
2424
- Send the CSI volume_id instead of PVC Name to the csi-driver in volumeCreate when datasource is PVC ([#310](https://github.com/kubernetes-csi/external-provisioner/pull/310), [@Madhu-1](https://github.com/Madhu-1))
25-
- Fixes nil pointer derefence in log when migration turned on ([#342](https://github.com/kubernetes-csi/external-provisioner/pull/342), [@davidz627](https://github.com/davidz627))
25+
- Fixes nil pointer dereference in log when migration turned on ([#342](https://github.com/kubernetes-csi/external-provisioner/pull/342), [@davidz627](https://github.com/davidz627))
2626
- Handle deletion of CSI migrated volumes ([#273](https://github.com/kubernetes-csi/external-provisioner/pull/273), [@ddebroy](https://github.com/ddebroy))
2727
- Reduced logging noise of unrelated PVCs. Emit event on successful provisioning. ([#351](https://github.com/kubernetes-csi/external-provisioner/pull/351), [@jsafrane](https://github.com/jsafrane))
2828
- Added extra verification of source Snapshot and PersistentVolumeClaim before provisioning. ([#352](https://github.com/kubernetes-csi/external-provisioner/pull/352), [@jsafrane](https://github.com/jsafrane))

pkg/capacity/provision.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func (p *provisionWrapper) Provision(ctx context.Context, options controller.Pro
6565
p.c.refreshSC(options.StorageClass.Name)
6666
}
6767
} else if state != controller.ProvisioningNoChange {
68-
// Unsuccesful provisioning might also be a reason why
68+
// Unsuccessful provisioning might also be a reason why
6969
// we have to refresh. We could try to identify the topology
7070
// via the selected node (if there is any), but more important
7171
// and easier is to refresh the objects for the storage

pkg/controller/controller_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ func TestGetSecretReference(t *testing.T) {
744744
},
745745
expectRef: &v1.SecretReference{Name: "pvcname", Namespace: "ns"},
746746
},
747-
"template - valid, provisioner with pvc name and namepsace": {
747+
"template - valid, provisioner with pvc name and namespace": {
748748
secretParams: provisionerSecretParams,
749749
params: map[string]string{
750750
provisionerSecretNameKey: "${pvc.name}",

pkg/controller/topology_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ func TestStatefulSetSpreading(t *testing.T) {
287287
},
288288
},
289289
},
290-
"select index 1 among allowedTopologies with multiple terms/multiple requirments for pvc with statefulset name:testset and id:2; ignore claimname:testpvcB": {
290+
"select index 1 among allowedTopologies with multiple terms/multiple requirements for pvc with statefulset name:testset and id:2; ignore claimname:testpvcB": {
291291
pvcName: "testpvcB-testset-2",
292292
allowedTopologies: []v1.TopologySelectorTerm{
293293
{

0 commit comments

Comments
 (0)