Skip to content

test: add codespell github workflow and templates for issues/RFEs. #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2022
Merged

test: add codespell github workflow and templates for issues/RFEs. #761

merged 2 commits into from
Aug 31, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jul 29, 2022 •
edited
Loading

Signed-off-by: Humble Chirammal [email protected]

/kind failing-test

-->

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2022
@humblec humblec changed the title test: add tirvy vulnerability scanner github action [WIP] test: add tirvy vulnerability scanner github action Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2022
@humblec humblec force-pushed the trivvy branch 3 times, most recently from ac8f0d5 to 525ddd7 Compare July 29, 2022 16:41
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2022
@humblec humblec changed the title [WIP] test: add tirvy vulnerability scanner github action test: add codespell github workflow and templates for issues/RFEs. Aug 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2022
ggriffiths
ggriffiths approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@ggriffiths ggriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@xing-yang
Copy link
Contributor

This looks good.

as discussed in kubernetes-csi/livenessprobe#149 (comment)

That comment is regarding trivy vulnerability scanner. I don't see anything about these changes. Did you add the right reference?

@humblec
Copy link
Contributor Author

humblec commented Aug 4, 2022

This looks good.

as discussed in kubernetes-csi/livenessprobe#149 (comment)

That comment is regarding trivy vulnerability scanner. I don't see anything about these changes. Did you add the right reference?

I was planning to add that too here, but on a second thought, kept only one action codespell and templates in this. Trivvy will be a follow up PR. I have removed that references from the comment.. @xing-yang

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9aa9392 into kubernetes-csi:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths ggriffiths approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@xing-yang xing-yang

@ggriffiths ggriffiths

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@humblec @xing-yang @k8s-ci-robot @ggriffiths