Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Use RFC3339 for time parse #158

Merged
merged 3 commits into from
Jan 7, 2017
Merged

Use RFC3339 for time parse #158

merged 3 commits into from
Jan 7, 2017

Conversation

resouer
Copy link
Collaborator

@resouer resouer commented Jan 5, 2017

hyperd now use RFC3339 for time parse everywhere, we need to keep consistency.

Will send a patch to private after this.

@resouer resouer requested a review from feiskyer January 5, 2017 14:06
@feiskyer
Copy link

feiskyer commented Jan 5, 2017

@resouer Any reference when hyperd changed this?

@resouer
Copy link
Collaborator Author

resouer commented Jan 6, 2017

@feiskyer I believe it's after this commit: hyperhq/hyperd@9f32482 , when created, err := utils.ParseTimeString(info.Created) is removed, and then no utils.ParseTimeString is used anymore.

@feiskyer
Copy link

feiskyer commented Jan 6, 2017

@resouer Got it. LGTM. Could you fix ci first?

@feiskyer feiskyer self-assigned this Jan 6, 2017
@resouer
Copy link
Collaborator Author

resouer commented Jan 6, 2017

Yes, I'm looking into it

@resouer resouer mentioned this pull request Jan 6, 2017
@feiskyer feiskyer merged commit 7e71367 into hyperhq:master Jan 7, 2017
@resouer resouer deleted the fix-time branch January 7, 2017 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants