Header frame with non-zero content-length and END_STREAM is malformed #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaufavor
force-pushed
the
content-length-end-header
branch
from
7f1b98d to
86d07ab
Compare
|
I'm fixing the MSRV job in #814. |
Before this change, content-length underflow is only checked when receiving date frames. The underflow error was never triggered if data frames are never received. This change adds similar check for headers frames.
eaufavor
force-pushed
the
content-length-end-header
branch
from
86d07ab to
24a065f
Compare
cxw620
pushed a commit
to hanyu-dev/miku-h2
that referenced
this pull request
Jan 20, 2025
* chore: allow matching infallible (hyperium#796) * v0.4.6 * chore(ci): use tokio-util 0.7.11 in MSRV check * style: replace `split_to` and `split_off` with better alternatives This removes `let _ = ` from in front of `split_to` and `split_off` and mostly follows the suggestions from the `#[must_use]` impls. One of the uses of `split_to` is instead replaced with `take`. * improve ci/h2spec.sh (macOS compat, /tmp dir and overwrite) (hyperium#809) - detect if run on MacOS, so we download h2spec macos build in that case - support overwriting h2spec detection so we anyway download new file, useful in case you switch to new version for example - move h2spec, archive and log all to /tmp dir as to not polute the repo dir * ci: pin hashbrown for msrv job (hyperium#814) * fix: HEADERS frame with non-zero content-length and END_STREAM is malformed (hyperium#813) Before this change, content-length underflow is only checked when receiving date frames. The underflow error was never triggered if data frames are never received. This change adds similar check for headers frames. * fix: notify_recv after send_reset() in reset_on_recv_stream_err() to ensure local stream is released properly (hyperium#816) (hyperium#818) Similar to what have been done in fn send_reset<B>(), we should notify RecvStream that is parked after send_reset(). Co-authored-by: Jiahao Liang <[email protected]> --------- Co-authored-by: Sean McArthur <[email protected]> Co-authored-by: tottoto <[email protected]> Co-authored-by: Paolo Barbolini <[email protected]> Co-authored-by: Glen De Cauwsemaecker <[email protected]> Co-authored-by: Yuchen Wu <[email protected]> Co-authored-by: Jiahao Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, content-length underflow is only checked when receiving date frames.
This change adds similar check for headers frames.