Skip to content

feat(pollux): add anoncreds predicate on requests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented May 20, 2024

Description:

Add ability to add predicates on anoncreds presentation requests.

Fixes ATL-6848 ATL-6517

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@mkbreuningIOHK
Copy link
Contributor

mkbreuningIOHK commented May 21, 2024

Added ATL-6517 as reference.
One question: the check 'I have made corresponding changes to the documentation` is there, but I do not see any document update in this PR. Could you clarify? (by the way, there is another sub-task in Jira for the documentation update).

@goncalo-frade-iohk
Copy link
Contributor Author

#141 (comment)

Although this actually doesn't add any documentation since I removed after since it was not needed anymore.

Documentation changes are comments done in Code 99% of the time not in other file.

 Fixes ATL-6848

Signed-off-by: goncalo-frade-iohk <[email protected]>
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/atl-6848-anoncreds-verification branch from df023de to c827435 Compare May 21, 2024 13:31
@goncalo-frade-iohk goncalo-frade-iohk merged commit 423daf4 into main May 22, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/atl-6848-anoncreds-verification branch May 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants