Skip to content

fix: did url string parsing correctly #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: did url string parsing correctly #97

merged 1 commit into from
Sep 1, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

No description provided.

hamada147
hamada147 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@antonbaliasnikov antonbaliasnikov changed the title fix: fix bug that is causing did url not string not parsed correctly fix: did url string parsing correctly Sep 1, 2023
@goncalo-frade-iohk goncalo-frade-iohk merged commit 93a3eb4 into main Sep 1, 2023
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/FixDIDUrlBug branch September 1, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@curtis-h curtis-h Awaiting requested review from curtis-h

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goncalo-frade-iohk @hamada147