Skip to content

Update go version to 1.24.0 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Vibhuair20
Copy link

all the go versions has been updated

@Vibhuair20
Copy link
Author

@mbrandenburger can you review and check
Let me know.
Thanks

@adecaro
Copy link
Contributor

adecaro commented Apr 13, 2025

please, we need to check that this change does not disrupt the token-sdk.
Also, I still think go1.23 as minimum version is enough.

@Vibhuair20
Copy link
Author

On #848
It was asked to update that

@Vibhuair20
Copy link
Author

hi any updates?

@adecaro
Copy link
Contributor

adecaro commented Apr 16, 2025

so, from my point of view, it makes more sense to do something like

go 1.23.0

toolchain go1.24.1

In this way, we set the minimum version to go1.23 but we run the code with go1.24.
What do you think?

@adecaro
Copy link
Contributor

adecaro commented Apr 16, 2025

for instance, I'm giving it a try on the token-sdk: hyperledger-labs/fabric-token-sdk#1041

@Vibhuair20
Copy link
Author

i saw your updates in the above sdk @adecaro
using the toolchain is a great option
But you still have issues with the golanggci-lint
Can i help you fix those issues and push a pr

@adecaro
Copy link
Contributor

adecaro commented Apr 22, 2025

Hi @Vibhuair20 will you update this PR or create a new one?

@Vibhuair20
Copy link
Author

Hi, i will update this pr only

@adecaro
Copy link
Contributor

adecaro commented Apr 22, 2025

great, thanks :)

@adecaro
Copy link
Contributor

adecaro commented Apr 23, 2025

@Vibhuair20 , any update? Thanks :)

@Vibhuair20
Copy link
Author

Vibhuair20 commented Apr 23, 2025 via email

igned-off-by: Vibhuair20 <[email protected]>

Signed-off-by: Vibhuair20 <[email protected]>
@Vibhuair20
Copy link
Author

sure i tried to update it let me now @adecaro

@Vibhuair20
Copy link
Author

hey i am still learning golnag is it possible that you can help me with it

@adecaro
Copy link
Contributor

adecaro commented Apr 27, 2025

sure, let me give it a try.

@adecaro
Copy link
Contributor

adecaro commented Apr 27, 2025

I cannot push to your branch, I'll create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants