Skip to content

refactor: replace deprecated context fetch #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

aaron-steinfeld
Copy link
Contributor

Description

GQL's context propagation was updated a long time back, and we've been relying on the deprecated mechanism (where an untyped object, rather than a map, is accessed). This puts the same value in the map and adds a simple util to access it in a type-safe way. All HTC usages have been updated

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner April 17, 2023 06:24
@github-actions
Copy link

Test Results

110 tests  ±0   110 ✔️ ±0   46s ⏱️ +5s
  38 suites ±0       0 💤 ±0 
  38 files   ±0       0 ±0 

Results for commit 69ce044. ± Comparison against base commit 9712c62.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #135 (69ce044) into main (9712c62) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main     #135      +/-   ##
============================================
- Coverage     57.58%   57.57%   -0.02%     
  Complexity      264      264              
============================================
  Files            90       91       +1     
  Lines          1443     1445       +2     
  Branches         42       42              
============================================
+ Hits            831      832       +1     
- Misses          582      583       +1     
  Partials         30       30              
Flag Coverage Δ
unit 57.57% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../graphql/common/fetcher/InjectableDataFetcher.java 0.00% <0.00%> (ø)
...ce/core/graphql/context/GraphQlRequestContext.java 0.00% <0.00%> (ø)
...l/context/DefaultGraphQlRequestContextBuilder.java 81.57% <100.00%> (+0.49%) ⬆️
...core/graphql/metadata/fetcher/MetadataFetcher.java 81.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-steinfeld aaron-steinfeld merged commit 3e90c7a into main Apr 17, 2023
@aaron-steinfeld aaron-steinfeld deleted the improve-context-fetch branch April 17, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants