Skip to content

refactor: remove composite tsconfig #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2023
Merged

refactor: remove composite tsconfig #2098

merged 2 commits into from
Mar 31, 2023

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Mar 31, 2023

Description

Please include a summary of the change, motivation and context.
composite tsconfigs are discouraged since ng v13.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner March 31, 2023 03:51
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2098 (cd8b6da) into main (95213d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files         905      905           
  Lines       19967    19967           
  Branches     2860     2860           
=======================================
  Hits        16599    16599           
  Misses       3217     3217           
  Partials      151      151           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 95a75b0 into main Mar 31, 2023
@anandtiwary anandtiwary deleted the remove-tsconfig.base branch March 31, 2023 04:22
@github-actions
Copy link

Unit Test Results

       4 files  ±0     304 suites  ±0   26m 11s ⏱️ + 1m 17s
1 093 tests ±0  1 093 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 101 runs  ±0  1 101 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 95a75b0. ± Comparison against base commit 95213d4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants