feat: upgrade to v15 #2230
Merged
feat: upgrade to v15 #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #2230 +/- ##
==========================================
- Coverage 82.69% 82.69% -0.01%
==========================================
Files 916 916
Lines 20421 20418 -3
Branches 3214 3214
==========================================
- Hits 16888 16885 -3
Misses 3405 3405
Partials 128 128
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Why not upgrade to v16 in the same flow? |
|
That would require us to upgrade hyperdash-angular first. We may also have to migrate to material MDC. |
This comment has been minimized.
This comment has been minimized.
adisreyaj
reviewed
Jun 21, 2023
| @@ -20,6 +20,7 @@ import { ChangeDetectionStrategy, Component, Input, OnChanges } from '@angular/c | |||
| </ng-container> | |||
| `, | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| encapsulation: ViewEncapsulation.ShadowDom, | |||
There was a problem hiding this comment.
because it uses keyframes.
In v15, the Angular compiler prefixes @keyframes in CSS with the component's scope.
This means that any TypeScript code that relies on keyframes names no longer works in v15.
Update any such instances to: define keyframes programmatically,
use global stylesheets, or change the component's view encapsulation.
[Read further](https://angular.io/guide/update-to-version-15#v15-bc-03)
There was a problem hiding this comment.
|
My dev server unexpectedly quits when I run this. I ran git checkout ng-15
git submodule update && npm i
npm run startIt took a few minutes to generate the bundle after running |
Weird. Is anyone else facing this issue? |
Okay, so this is the result of running |
|
For anyone else getting an OOM error, increase the memory limit in Here was my error: src_app_settings_label-management_label-management-routing_module_ts.js | label-management-label-management-routing-module | 3.56 kB |
src_app_settings_reports_reports-routing_module_ts.js | reports-reports-routing-module | 2.36 kB |
Build at: 2023-06-21T05:50:05.843Z - Hash: 202c975fccccaa83 - Time: 188939ms
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
✔ Compiled successfully.
⠧ Generating browser application bundles (phase: building)...
<--- Last few GCs --->
[72787:0x140008000] 243904 ms: Scavenge 3976.0 (4127.9) -> 3962.1 (4127.9) MB, 6.0 / 0.0 ms (average mu = 0.214, current mu = 0.076) allocation failure
[72787:0x140008000] 245550 ms: Mark-sweep 3976.8 (4128.6) -> 3961.3 (4129.6) MB, 1570.1 / 0.0 ms (average mu = 0.163, current mu = 0.108) allocation failure scavenge might not succeed
<--- JS stacktrace --->
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x1025571dc node::Abort() [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
2: 0x1025573cc node::ModifyCodeGenerationFromStrings(v8::Local<v8::Context>, v8::Local<v8::Value>, bool) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
3: 0x10269a040 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
4: 0x10269a000 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
5: 0x10281d52c v8::internal::Heap::GarbageCollectionReasonToString(v8::internal::GarbageCollectionReason) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
6: 0x102820b3c v8::internal::Heap::CollectSharedGarbage(v8::internal::GarbageCollectionReason) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
7: 0x10281dcf4 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
8: 0x10281b61c v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
9: 0x102827394 v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
10: 0x102827428 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
11: 0x1027fa2bc v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
12: 0x102b32480 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
13: 0x102e4592c Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
14: 0x108b37664
15: 0x1097164dc
16: 0x107b8e9a8
17: 0x107b63eb0
18: 0x108a257a4
19: 0x108ab0788
20: 0x107ec8198
21: 0x1085aef18
22: 0x1085ae4e4
23: 0x109c8d8c0
24: 0x108b09ef8
25: 0x1085aeac4
26: 0x109c8d8c0
27: 0x108b09ef8
28: 0x1085aeac4
29: 0x108fa3438
30: 0x1076274b4
31: 0x108572550
32: 0x1099d0e98
33: 0x1084cf9e0
34: 0x1085729e4
35: 0x1099d0e98
36: 0x109d8d078
37: 0x107ceb490
38: 0x109d8d078
39: 0x107db59dc
40: 0x1085725cc
41: 0x1099d0e98
42: 0x1084cfd18
43: 0x1085729e4
44: 0x10805efb4
45: 0x108571ac0
46: 0x1099d0e98
47: 0x109d8d19c
48: 0x107cee070
49: 0x1085727f0
50: 0x1099d0e98
51: 0x108a2ba30
52: 0x1095e51c4
53: 0x1084c85a0
54: 0x107b62b20
55: 0x10917a278
56: 0x109c5546c
57: 0x109d4a460
58: 0x107fd384c
59: 0x102e08bb4 Builtins_AsyncFunctionAwaitResolveClosure [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
60: 0x102e8da18 Builtins_PromiseFulfillReactionJob [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
61: 0x102dfaf94 Builtins_RunMicrotasks [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
62: 0x102dd7284 Builtins_JSRunMicrotasksEntry [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
63: 0x1027a9ccc v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
64: 0x1027aa100 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
65: 0x1027aa1ec v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*, v8::internal::MaybeHandle<v8::internal::Object>*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
66: 0x1027cce28 v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
67: 0x1027cd6bc v8::internal::MicrotaskQueue::PerformCheckpoint(v8::Isolate*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
68: 0x102ddbc94 Builtins_CallApiCallback [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
69: 0x108bae320
70: 0x102dd73ac Builtins_JSEntryTrampoline [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
71: 0x102dd7044 Builtins_JSEntry [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
72: 0x1027a9d04 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
73: 0x1027a9398 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
74: 0x1026b6a24 v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
75: 0x1024a4d00 node::InternalCallbackScope::Close() [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
76: 0x1024a4fc8 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
77: 0x1024a52b0 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
78: 0x1024feab0 node::Environment::CheckImmediate(uv_check_s*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
79: 0x102dc1850 uv__run_check [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
80: 0x102dbb5ac uv_run [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
81: 0x1024a56d4 node::SpinEventLoop(node::Environment*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
82: 0x102591138 node::NodeMainInstance::Run(int*, node::Environment*) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
83: 0x102590e18 node::NodeMainInstance::Run() [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
84: 0x102528994 node::Start(int, char**) [/Users/thomas/.nvm/versions/node/v16.19.0/bin/node]
85: 0x18b997f28 start [/usr/lib/dyld]
[1] 72781 abort npm run start
➜ traceable-ui git:(ng-15) ✗ |
Exac
reviewed
Jun 21, 2023
Exac
reviewed
Jun 21, 2023
jake-bassett
previously approved these changes
Jul 7, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.