Skip to content

Fabric API key still required in info.plist #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surdu opened this issue May 10, 2018 · 11 comments
Open

Fabric API key still required in info.plist #130

surdu opened this issue May 10, 2018 · 11 comments

Comments

@surdu
Copy link

surdu commented May 10, 2018

The documentation mentions the configuration for iOS is not needed anymore, but when building for iOS I got an error that the Fabric key was missing from info.plist dict.

I managed to find the needed info.plist code in an older version of the readme.

I'm using the @next version.

@hypery2k
Copy link
Owner

can link the documentation where the API key isn't needed anymore? cannot find it

@hypery2k hypery2k added this to the 2.0 milestone May 15, 2018
@hypery2k hypery2k self-assigned this May 15, 2018
@hypery2k hypery2k removed this from the 2.0 milestone May 15, 2018
@surdu
Copy link
Author

surdu commented May 15, 2018

@hypery2k
Copy link
Owner

it basically means you don't have to add it manually.

@surdu
Copy link
Author

surdu commented May 15, 2018

This is what I'm trying to tell you: you have to add it manually, otherwise you get the following error when the application starts:

2018-05-15 11:33:26.942824+0300  localhost capangoseeker[32602]: (CoreFoundation) *** Terminating app due to uncaught exception 'FAB
Exception', reason: '[Fabric] Value of Info.plist key "Fabric" must be a NSDictionary.'
*** First throw call stack:
(
        0   CoreFoundation                      0x0000000117e7612b __exceptionPreprocess + 171
        1   libobjc.A.dylib                     0x0000000116dc0f41 objc_exception_throw + 48
        2   CoreFoundation                      0x0000000117eeb245 +[NSException raise:format:] + 197
        3   capangoseeker                       0x000000010fe254f4 -[Fabric validFabricConfigFromInfoPlist:] + 353

@hypery2k
Copy link
Owner

could you try with 2.0.2?

@etabakov
Copy link

etabakov commented May 22, 2018

Looks the same with 2.0.2. Just tested. Even after manually adding it in the Info.plist, I get the following error during build:

2018-05-22 19:07:43.048 uploadDSYM[95656:2021109] Fabric.framework/run 1.7.0 (208)
error: Fabric: Configuration Issue
Fabric API key not valid. Your Fabric run script build phase should contain your API key:
./Fabric.framework/run INSERT_YOUR_API_KEY INSERT_YOUR_BUILD_SECRET

@hypery2k
Copy link
Owner

that's strange. CI is working so far even for iOS. Can you share your project? Which NativeScript version you're using?

@stevegardnersa
Copy link

I have the same issue and tried adding the key to the plist file but received the same error as @etabakov. Interesting that the error shows is looking for the build phase in Fabric.framework/run but the hook has it writing to Fabric/run. I tried changing the hook to write to Fabric.framework/run but this didn't work either.

Xcode: 9.4
Nativescript: 4.1.0
tns-core-modules: 4.0.1
tns-ios: 4.0.1

@fthuin
Copy link

fthuin commented Jul 26, 2018

I can confirm same error happens for me.

Xcode 9.4
Nativescript 4.1
tns-core-modules 4.1
tns-ios 4.1.1

hypery2k added a commit that referenced this issue Jul 30, 2018
@maatthc
Copy link

maatthc commented Aug 20, 2018

Hi guys,
I also needed to add to Info.plist:

APIKey

Kits


KitInfo

KitName
Answers


KitInfo

KitName
Crashlytics


Now it is working..

Cheers,
Alex

@cmckni3
Copy link

cmckni3 commented Nov 27, 2018

Same here. I had to add this to my Info.plist or the app would crash after starting.

  <key>Fabric</key>
  <dict>
    <key>APIKey</key>
    <string>{{API_KEY_HERE}}</string>
    <key>Kits</key>
    <array>
      <dict>
        <key>KitInfo</key>
        <dict/>
        <key>KitName</key>
        <string>Crashlytics</string>
      </dict>
    </array>
  </dict>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants