-
Notifications
You must be signed in to change notification settings - Fork 104
fix(deps): add downstream peer dependencies #120
Conversation
Fixes iamturns#6 by adding downstream peer dependencies to this package (we add the React specific dependencies as optional). This also enables Yarn v2 support (which requires upstream packages to include their dependency's peer dependencies).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thank you! Just one question about a version number. Cheers!
"@typescript-eslint/eslint-plugin": "^3.6.1" | ||
"@typescript-eslint/eslint-plugin": "^3.6.1", | ||
"eslint": "^5.16.0 || ^6.8.0 || ^7.2.0", | ||
"eslint-plugin-import": "^2.21.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious where this version came from?
In both eslint-config-airbnb and eslint-config-airbnb-base they reference ^2.22.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got that version from the warning logs when installing with Yarn V2 PNP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the peer dependency version was updated pretty recently in eslint-config-airbnb
. Maybe the warning log you referenced was slightly outdated. Can you update this line ^2.22.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a bit hard to maintain. To mimic other libraries' peer dependencies will just go out of sync with time. I think it's cleaner to deal with this problem to decouple this library's dependencies from airbnb as much as possible and instead provide guidance on how to deal with these.
An alternative approach is proposed here #201
this doesn't help, because this repo doesn't depend on :
But eslint-config-airbnb does, please read my comment |
Fixes #6 by adding downstream peer dependencies to this package (we add
the React specific dependencies as optional).
This also enables Yarn v2 support (which requires upstream packages to
include their dependency's peer dependencies).