Skip to content

allow converts objectID to string #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2020
Merged

allow converts objectID to string #196

merged 3 commits into from
Oct 17, 2020

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Oct 15, 2020

objectID pass between service.actions should be converted to string automatically, all params of moleculer-db-adapter-mongoose's actions does not accept objectID instance. If dev want an objectID instance, he should call with convert:true

@coveralls
Copy link

coveralls commented Oct 15, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.588% when pulling 825e2db on 0x0a0d:master into 37b6c38 on icebob:master.

@erfanium erfanium self-requested a review October 15, 2020 06:48
erfanium
erfanium requested changes Oct 15, 2020
View reviewed changes
@0x0a0d 0x0a0d changed the title ensure objectID is string allow converts objectID to string Oct 16, 2020
@erfanium erfanium self-requested a review October 16, 2020 22:01
@erfanium erfanium requested a review from icebob October 16, 2020 22:07
erfanium
erfanium approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@erfanium erfanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erfanium erfanium merged commit 8d642aa into icebob:master Oct 17, 2020
@erfanium
Copy link
Collaborator

@icebob
It's better to release soon, several features have been added from the previous release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

@erfanium erfanium erfanium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x0a0d @coveralls @erfanium @icebob